Add GeoJson clustering #7208
Add GeoJson clustering #7208
Conversation
…geojson-clustering
…geojson-clustering
| const dataSource = await this.loadGeoJsonDataSource(geoJsonWgs84); | ||
|
|
||
| if (this.clustering.enabled) { | ||
| const pinBackgroundColor = this.clustering.pinBackgroundColor; |
There was a problem hiding this comment.
I don't know anything about runInAction(...), but a lot of the surrounding code uses that for accessing things in this. Does this code not need that for some reason?
There was a problem hiding this comment.
Hi @pjonsson,
runInAction, like action, is required when you modify an observable.
This code acts before the modification and the modification is already in a runInAction (at line 635).
So, this code not need runInAction.
|
Hello, any news? |
|
@glughi Hi, Giovanni. Thank you for your efforts and submission! The code looks good to me, but I could not observe any clustering on my local copy after adding your suggested parameters to the "GeoJSON Test" item from the default {
"id": "DL4Av6wY5h",
"type": "geojson",
"name": "GeoJSON Test",
"url": "test/bike_racks.geojson",
"clustering": {
"enabled": true
}
},What did I miss? |
|
Hello @niktayv, you're right. This clustering is currently only activated if you define |
3 participants
What this PR does
This PR adds the trait
ClusteringTraitstoGeoJsonTraits. In this way, it becomes possible to enable the clustering of entities made available by Cesium. Clusterized entities are represented as billboards generated by thefromTextfunction ofPinBuilderand report the number of grouped entities. As a result, clustering only works by using Cesium as a viewer, but there are no drawbacks to switching from Cesium to Leaflet at runtime.Test me
Add a GeoJson or WFS layer of points to the catalog and use new parameters
In example:
Checklist
doc/.